tests: unittest: adding unit tests for ble_gq lib #314
Conversation
|
You can find the documentation preview for this PR here. |
tests/lib/ble_gq/src/unity_test.c
Outdated
| uint16_t conn_handle = 0x0C4; | ||
|
|
||
| ble_evt.header.evt_id = BLE_GAP_EVT_DISCONNECTED; | ||
| ble_evt.evt.gap_evt.conn_handle = 0x0C4; |
There was a problem hiding this comment.
Nit: I would consider defining 0x0C4 somewhere and then reusing the definition in all the different occurrences, rather than hardcoding the value.
|
No milestone required for tests |
tests/lib/ble_gq/src/unity_test.c
Outdated
| for (int i = 0; i < ble_gq.max_conns; i++) { | ||
| ble_gq.conn_handles[i] = i + 1; | ||
| } |
There was a problem hiding this comment.
We should not alter the ble_gq ourselves. Perhaps register up to max_conns handlers successfully, then see that the next fails?
tests/lib/ble_gq/src/unity_test.c
Outdated
| sys_slist_init(&ble_gq.req_queue[0]); | ||
| sys_slist_append(&ble_gq.req_queue[0], &req.node); |
There was a problem hiding this comment.
There should be another way to append these than by altering the struct with slist. Use ble_gq_item_add()?
MechanicV1
force-pushed
the
ble_gq_unittest
branch
3 times, most recently
from
54395ef to
651a388
Compare
Added unit tests for ble_gq library Signed-off-by: Nirmal Krishna <[email protected]> Co-authored-by: Andreas Moltumyr <[email protected]>
MechanicV1
force-pushed
the
ble_gq_unittest
branch
from
651a388 to
30b2973
Compare
| TEST_ASSERT_EQUAL(NRF_ERROR_INVALID_STATE, glob_error); | ||
| } | ||
|
|
||
| void test_ble_gq_item_add_req_gatt_write(void) |
There was a problem hiding this comment.
| void test_ble_gq_item_add_req_gatt_write(void) | |
| void test_ble_gq_item_add_req_gattc_write_error_resources(void) |
There was a problem hiding this comment.
there are more cases like this. When not having a error at the end, we expect it to test a successful case. In this (and the other) case it is not, as the handler is called with an error.
| TEST_ASSERT_EQUAL(NRF_ERROR_RESOURCES, glob_error); | ||
| } | ||
|
|
||
| void test_ble_gq_item_add_req_srv_discovery(void) |
There was a problem hiding this comment.
| void test_ble_gq_item_add_req_srv_discovery(void) | |
| void test_ble_gq_item_add_req_srv_discovery_timeout(void) |
| ble_gq.conn_handles[0] = 0; | ||
|
|
||
| __cmock_sd_ble_gattc_write_ExpectAndReturn(conn_handle, &req.gattc_write, NRF_ERROR_BUSY); | ||
| __cmock_sd_ble_gattc_write_IgnoreAndReturn(NRF_ERROR_RESOURCES); |
There was a problem hiding this comment.
I don't see any test where the second call returns success, and we check glob_error for NRF_SUCCESS.
4 participants
Added unit tests for ble_gq library